I just found out the hard way that there is no warning when closing my unsaved project. I accidentally hit CMD+W instead of CMD+E and... POOF! my project was gone! yup, the key command to close the window is right next to the command to make it go live (and just above the command to save it!). YIKES! luckily I had saved it not too long before this happened so I didn't lose a ton of work... this time.
Feature request - warning/confirm dialog when closing unsaved projects
johannes
#2
Sorry to hear, it is supposed to be there, but the implementation is probably uncomplete. Not all actions on a patch set the "dirty" flag, most notable is editing scripts. This flag determines if a patch has been modified since opening.
ouch....
as @johannes pointed out, there is a warning, ( and I can confirm its active for keyboard shortcut too), but it appears there are some changes which are not marking the patch as dirty.
so what we really need to know, is what changes did you make that were not saved... and can you reproduce?
a couple of proposals (for @johannes really)
- perhaps we should change the shortcut to CMD+L (easier to remember too, I never use CMD+E as never remember it!)
- a visual indicator on the patch window, that it is 'dirty' , this will let the user know, but also it means we will be able to track changes that are not setting the dirty flag appropriately) ... pretty common on apps, using (*) next to filename on titlebar.
two relatively easy changes, that might move us forward a step or two...
thoughts?
johannes
#5
cmd/ctrl-e was chosen as it is also the shortcut for edit mode in Pd.
But Pd compatibility is not a goal.
A visual indicator for the dirty flag is a good idea. Yeah, asterisk after the filename in titlebar.
lab77
#6
I don't remember what I was doing in the project when this happened. and of course now I'm trying to reproduce it and it's working properly. XD
I'll update if I can isolate what might be the cause.
lab77
#7
OK, I was able to repeat what appears to be the bug with the warning pop up I was experiencing. The issue is I don't get a warming pop up if I hit CMD+W after coming back from Live mode. Basically if I make any changes then close the window before live mode I get a warning, but if I go live then come back and close the window I get no warning. I hope that makes sense. I also don't get a warning pop up if I close the window in live mode as well.
johannes
#8
Thanks, your analysis was very helpful to spot the cause!
This fix will make it into the next release.