Axoloti TEST release 1.0.9


#101

Ok, just a quick test so far, I can verify that 'edit object definition' and the edit button in a patch/object object seems to do the same thing now.

However, there seems to be something odd with the logic, but it can also be that I don't understand exactly how it's supposed to work.

If I make a change to the k-rate code, for instance, and click the close button on the window, I get the dialog 'Unsaved changes, do you want to apply? (Yes/No/Cancel)'. However, if I click Yes, the next time I click edit, then close,I get the same question, indicating that the changes weren't in fact applied last time. Looking at my edited code, it looks like they were in fact applied, and the generated xpatch.cpp confirms this too. I would have expected that once I've applied the changes once, I wouldn't get the question again, because that implies that the changes weren't in fact applied the first time.

What does the 'Apply' option in the File menu actually do? - in a similar vain, even if I've selected this, I get the same 'Unsaved changes...' dialog when I close the editor (which seems consistent with the rest of the behavior though).

It's not that the 'Unsaved...' dialog comes up every time I open the object editor, if I open it and don't make any changes at all it doesn't come up. So it seems that the object editor considers the object to have changed if there were any changes made since the editor was opened the first time, not since the last time the changes were applied.

Ok, got to go... sorry for being brief.


#102

its no big deal, just fixed it. ... will be available when the PR is accepted.

unfortunately the editors report strings as empty (e.g. "") but then we have to changes this to null, to ensure we dont have empty cdata sections, but instead an empty xml tag.
but now that I've moved to using the xml to see if the objects has changed, I was missing this in one location... so was comparing an empty tag vs a empty cdata section, so though it was different.
anyway works now
note: the two things behave identical, so the version you have is working fine, except for this warning.

(btw: you may find if you edit an existing patch/object that has this saved incorrectly due to a previous version 'bug' then you might get the warning the first time as it 'corrects' itself)


#103

Hi, I just did a 'git pull' and built the project. Now I get a red message in the Axoloti window when I start:
Object produced with newer version of Axoloti /home/gabriel/axoloti/axoloti-contrib/objects/tb/midi/utils/midiled.axo 1.0.10
Object produced with newer version of Axoloti /home/gabriel/axoloti/axoloti-contrib/objects/tb/midi/utils/midithru.axo 1.0.10
finished loading objects

I tried 'git pull --tags' but it says I am already up to date. The build version is 1.0.9-26-g29d28e9-dirty

Did I do something wrong here? and why do those two axo objects report being made with 1.0.10?


#104

no, you've not done anything wrong ...
1.0.10 is not released so the tag doesn't exist, except on my own repo :wink:
i'll edit the objects manually to put them back to 1.0.9.

(it doesn't matter for the released 1.0.9 as that doesn't have the new 1.0.10 version checking code)

EDIT: ok, objects are now 1.0.9 , so you wont get the error... you just need to sync the library again.


#105

OK, thanks for explaining this to me. Cheers!


#106

Got around to testing it now, again just a brief test but the save stuff seems to work as I would expect now.

Another thing that seems to be fixed is that prior to this PR, often whenever I alt-tabbed or otherwise changed focus from the patch/object editor to another window, the editor would scroll to the end of my code (I have more k-rate code than fits on the screen for the particular object I'm working on). Now the editor doesn't do that and just remains in the same location, also it seems to remember where I was editing, even after closing it and reopening it, which good - before, I was forever scrolling back to get to the position in the code where I was editing.

The 'Generate and Compile code' option in the Patch menu looks good to me, actually, at first it looks like a heading and there's a slight surprise when it is actually clickable but of course I know it is since it's been up for discussion. Anyway I think it's clearer now, would be good if someone who's never seen it before could provide a reaction to it too as my mind has now been poisoned by the fact that I know how it works... :smile:


#107

cool, sounds as if we have made some progress...

yeah, same fate here... each person has their own workflow, so when I test things, of course, the way I use it works, but give it to someone else - and it obviously doesn't. at work, Id have a QA team and other developers (and more time) so these things get ironed out quickly, but not the case here...
I think, I underestimated the effort on getting the editing to work with the object editor... and all the knock-on effects its had, but its getting there.... which honestly is a bit of a relief :wink:


#108

You deserver some sort of virtual medal for all the stuff you do with axoloti. Thanks! If i ever get a baby again, ill name him/her thetechnobear


#109

I second that. I'm sure we all appreciate your hard work, thetechnobear

a|x


#110

I found an minor error in the delay/write sdram.
In the choose box it reads 2.37sec while its value actually is 2,73sec.


#111

thanks , fixed (1.09 +) ... if you sync factory lib you'll pick up the change


#112

Did a quick search in the topic and i could not find anything.

I'm getting this error when using the object editor:

org.simpleframework.xml.core.ElementException: Value for @org.simpleframework.xml.Element(name=, type=void, data=false, required=true) on field 'MinValue' axoloti.datatypes.ValueInt32 axoloti.parameters.ParameterInt32Box.MinValue is null in class axoloti.parameters.ParameterInt32Box
org.simpleframework.xml.core.ElementException: Value for @org.simpleframework.xml.Element(name=, type=void, data=false, required=true) on field 'MinValue' axoloti.datatypes.ValueInt32 axoloti.parameters.ParameterInt32Box.MinValue is null in class axoloti.parameters.ParameterInt32Box
    at org.simpleframework.xml.core.Composite.writeUnion(Composite.java:1122)
    at org.simpleframework.xml.core.Composite.writeElements(Composite.java:1098)
    at org.simpleframework.xml.core.Composite.writeSection(Composite.java:1004)
    at org.simpleframework.xml.core.Composite.write(Composite.java:975)
    at org.simpleframework.xml.core.Composite.write(Composite.java:952)
    at org.simpleframework.xml.core.Traverser.write(Traverser.java:236)
    at org.simpleframework.xml.core.CompositeInlineList.write(CompositeInlineList.java:268)
    at org.simpleframework.xml.core.CompositeInlineList.write(CompositeInlineList.java:245)
    at org.simpleframework.xml.core.CompositeListUnion.write(CompositeListUnion.java:302)
    at org.simpleframework.xml.core.CompositeListUnion.write(CompositeListUnion.java:274)
    at org.simpleframework.xml.core.CompositeListUnion.write(CompositeListUnion.java:246)
    at org.simpleframework.xml.core.Composite.writeElement(Composite.java:1256)
    at org.simpleframework.xml.core.Composite.writeElement(Composite.java:1239)
    at org.simpleframework.xml.core.Composite.writeUnion(Composite.java:1127)
    at org.simpleframework.xml.core.Composite.writeElements(Composite.java:1098)
    at org.simpleframework.xml.core.Composite.writeSection(Composite.java:1004)
    at org.simpleframework.xml.core.Composite.writeElements(Composite.java:1087)
    at org.simpleframework.xml.core.Composite.writeSection(Composite.java:1004)
    at org.simpleframework.xml.core.Composite.write(Composite.java:975)
    at org.simpleframework.xml.core.Composite.write(Composite.java:952)
    at org.simpleframework.xml.core.Traverser.write(Traverser.java:236)
    at org.simpleframework.xml.core.Traverser.write(Traverser.java:208)
    at org.simpleframework.xml.core.Traverser.write(Traverser.java:186)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1180)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1162)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1140)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1259)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1241)
    at org.simpleframework.xml.core.Persister.write(Persister.java:1222)
    at axoloti.objecteditor.AxoObjectEditor.FireObjectModified(AxoObjectEditor.java:247)
    at axoloti.objecteditor.AxoObjectEditor.<init>(AxoObjectEditor.java:183)
    at axoloti.object.AxoObject.OpenEditor(AxoObject.java:296)
    at axoloti.object.AxoObjectInstance$2.actionPerformed(AxoObjectInstance.java:161)
    at java.awt.MenuItem.processActionEvent(MenuItem.java:669)
    at java.awt.MenuItem.processEvent(MenuItem.java:628)
    at java.awt.MenuComponent.dispatchEventImpl(MenuComponent.java:351)
    at java.awt.MenuComponent.dispatchEvent(MenuComponent.java:339)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:761)
    at java.awt.EventQueue.access$500(EventQueue.java:97)
    at java.awt.EventQueue$3.run(EventQueue.java:709)
    at java.awt.EventQueue$3.run(EventQueue.java:703)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
    at java.awt.EventQueue$4.run(EventQueue.java:731)
    at java.awt.EventQueue$4.run(EventQueue.java:729)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

New patch -> insert a patch/object object in the workspace-> edit -> parameters -> add -> select parameter int32box (actually it does this error with other classes)
The big red error manifests itself, only way to fix is to close the patch and reopen it.
I think it has to do with the fact that object editor is still not complete, therefore you can't edit parameters like minvalue and maxvalue that are essential for int class parameters.


#113

fixed in the git development repository, soon in a release...


#115

Reset to default doesnt work for me.


#116

stomps/delay not working anymore: delay size has been changed


#117

3 posts were merged into an existing topic: Axoloti TEST release 1.0.10


#118

Sorry @Sputnki meant to reply to the thread, not your last post there.

a|x


#119

Axoloti TEST release 1.0.10